Skip to content

Rpc pack management (#1368)#2296

Merged
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/RpcPackManagement
Dec 8, 2025
Merged

Rpc pack management (#1368)#2296
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/RpcPackManagement

Conversation

@grasci-arm

Copy link
Copy Markdown
Collaborator
  • Support for SelectPack RPC interface

  • Adjusted to changes in RPC protocol

  • Enhanced unit tests and fixes

  • increment csolution-rpc version dependency

  • Fix Compiler errors

  • Fix Compiler errors

  • Update tools/projmgr/include/ProjMgrRpcServerData.h

Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com

  • Update tools/projmgr/src/ProjMgrRpcServer.cpp

Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com

  • Update tools/projmgr/src/ProjMgrRpcServer.cpp

Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com

  • Spell corrections

  • Update tools/projmgr/src/ProjMgrRpcServer.cpp

Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com

  • Update tools/projmgr/test/src/ProjMgrRpcTests.cpp

Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com


Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com

* Support for SelectPack RPC interface

* Adjusted to changes in RPC protocol

* Enhanced unit tests and fixes

* increment csolution-rpc version dependency

* Fix Compiler errors

* Fix Compiler errors

* Update tools/projmgr/include/ProjMgrRpcServerData.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tools/projmgr/src/ProjMgrRpcServer.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tools/projmgr/src/ProjMgrRpcServer.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Spell corrections

* Update tools/projmgr/src/ProjMgrRpcServer.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tools/projmgr/test/src/ProjMgrRpcTests.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown

Test Results

  7 files   53 suites   5m 38s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit deac0d1.

♻️ This comment has been updated with latest results.

Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Dismissed
Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Dismissed
@edriouk edriouk merged commit e7b5d81 into Open-CMSIS-Pack:main Dec 8, 2025
83 of 84 checks passed
@edriouk edriouk deleted the outbound/RpcPackManagement branch December 8, 2025 14:07
@codecov

codecov Bot commented Dec 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.01377% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.32%. Comparing base (d8943b6) to head (deac0d1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrRpcTests.cpp 50.58% 0 Missing and 85 partials ⚠️
tools/projmgr/src/ProjMgrRpcServer.cpp 76.74% 1 Missing and 39 partials ⚠️
tools/projmgr/src/ProjMgrRpcServerData.cpp 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
+ Coverage   66.24%   66.32%   +0.07%     
==========================================
  Files         181      181              
  Lines       36346    36547     +201     
  Branches    22544    22711     +167     
==========================================
+ Hits        24077    24238     +161     
+ Misses       7678     7626      -52     
- Partials     4591     4683      +92     
Flag Coverage Δ
buildmgr-cov 74.23% <ø> (ø)
packchk-cov 70.25% <ø> (ø)
projmgr-cov 80.29% <65.01%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrRpcServerData.h 100.00% <ø> (ø)
tools/projmgr/include/ProjMgrWorker.h 75.86% <ø> (ø)
tools/projmgr/src/ProjMgrCbuildPack.cpp 100.00% <100.00%> (ø)
tools/projmgr/src/ProjMgrWorker.cpp 88.11% <100.00%> (+0.01%) ⬆️
tools/projmgr/src/ProjMgrRpcServerData.cpp 82.73% <75.00%> (-0.66%) ⬇️
tools/projmgr/src/ProjMgrRpcServer.cpp 83.11% <76.74%> (+10.68%) ⬆️
tools/projmgr/test/src/ProjMgrRpcTests.cpp 52.90% <50.58%> (-2.29%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants